Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace savedObjectRepository with savedObjectClient #156

Merged
merged 1 commit into from
Sep 14, 2023

Conversation

Hailong-am
Copy link
Collaborator

Description

Replace savedObjectRepository with savedObjectClient for workspace name unique check

Issues Resolved

Screenshot

Testing the changes

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
    • yarn test:ftr
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@codecov-commenter
Copy link

Codecov Report

Merging #156 (11c20ec) into workspace (aa51f84) will decrease coverage by 25.93%.
Report is 1 commits behind head on workspace.
The diff coverage is n/a.

@@              Coverage Diff               @@
##           workspace     #156       +/-   ##
==============================================
- Coverage      60.68%   34.75%   -25.93%     
==============================================
  Files           2898     1922      -976     
  Lines          56631    38148    -18483     
  Branches        9077     5464     -3613     
==============================================
- Hits           34364    13257    -21107     
- Misses         20244    24287     +4043     
+ Partials        2023      604     -1419     
Flag Coverage Δ
Linux_1 34.75% <ø> (?)
Windows_1 ?
Windows_2 ?
Windows_3 ?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1560 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Hailong-am Hailong-am merged commit f350eb3 into ruanyl:workspace Sep 14, 2023
39 of 46 checks passed
opensearch-workspace-development bot pushed a commit that referenced this pull request Sep 14, 2023
…me validation (#156)

Signed-off-by: Hailong Cui <[email protected]>
(cherry picked from commit f350eb3)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Hailong-am pushed a commit that referenced this pull request Sep 15, 2023
…me validation (#156) (#160)

(cherry picked from commit f350eb3)

Signed-off-by: Hailong Cui <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ruanyl pushed a commit that referenced this pull request Sep 15, 2023
SuZhou-Joe pushed a commit that referenced this pull request Sep 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants